Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collect tsdb #429

Merged
merged 6 commits into from
Feb 15, 2023
Merged

Add collect tsdb #429

merged 6 commits into from
Feb 15, 2023

Conversation

nexustar
Copy link
Contributor

@nexustar nexustar commented Feb 3, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

@nexustar nexustar force-pushed the add_collect_tsdb branch 3 times, most recently from 22642e0 to 1783437 Compare February 14, 2023 09:39
@codecov-commenter
Copy link

Codecov Report

Base: 28.52% // Head: 30.11% // Increases project coverage by +1.59% 🎉

Coverage data is based on head (d79cd46) compared to base (b05d398).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   28.52%   30.11%   +1.59%     
==========================================
  Files          52       50       -2     
  Lines        4523     4218     -305     
==========================================
- Hits         1290     1270      -20     
+ Misses       3063     2778     -285     
  Partials      170      170              
Flag Coverage Δ
unittests 30.11% <100.00%> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/diag/command/collect.go 34.23% <100.00%> (+0.60%) ⬆️
cmd/diag/command/collectdm.go 30.77% <100.00%> (+0.67%) ⬆️
pkg/models/metadata.go
pkg/models/tidbcluster.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaaaaaaang kaaaaaaang merged commit c0cacb0 into pingcap:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants