feat: add site setting upload_max_body_size #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@sszgwdk is attempting to deploy a commit to the pingcap Team on Vercel. A member of the Team first needs to authorize it. |
634750802
added
require-build
e2e-frontend:branch-main
and removed
require-build
e2e-frontend:branch-main
labels
634750802
changed the title
Mini256
reviewed
Dec 13, 2024
Comment on lines
37
to
39
| if SiteSetting.setting_exists("upload_max_body_size"): | ||
| sys_upload_max_body_size = SiteSetting.get_setting("upload_max_body_size") | ||
| if file.size > sys_upload_max_body_size: |
There was a problem hiding this comment.
As the __getattr__ method has been overrided,
You can just:
Suggested change
| if SiteSetting.setting_exists("upload_max_body_size"): | |
| sys_upload_max_body_size = SiteSetting.get_setting("upload_max_body_size") | |
| if file.size > sys_upload_max_body_size: | |
| sys_upload_max_body_size = SiteSetting.upload_max_body_size | |
| if sys_upload_max_body_size: | |
| if file.size > sys_upload_max_body_size: |
|
|
||
| upload: | ||
| upload_max_body_size: | ||
| default: 10485760 |
There was a problem hiding this comment.
Suggested change
| default: 10485760 | |
| default: 10485760 # 10MB |
| if file.size > sys_upload_max_body_size: | ||
| raise HTTPException( | ||
| status_code=status.HTTP_413_REQUEST_ENTITY_TOO_LARGE, | ||
| detail=f"File size({file.size}) exceeds maximum allowed size({sys_upload_max_body_size})", |
There was a problem hiding this comment.
Can me make the file size humam-readble?
Co-authored-by: Mini256 <[email protected]>
Co-authored-by: Mini256 <[email protected]>
Co-authored-by: Mini256 <[email protected]>
Co-authored-by: Mini256 <[email protected]>
sykp241095
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug #382