Initialize CPU and hardware registers to post-bootrom values #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the values found at
https://gbdev.io/pandocs/Power_Up_Sequence.html#console-state-after-boot-rom-hand-off.
I also moved these values from the
LR35902
constructor to thefpt
library crate root module, in aGameboy
method, that is optionally called fromfpt-cli
by passing--fake-bootrom dmg0
as the first argument in the CLI (maybe this should be the default, instead of fully emulating the bootrom?)I'm open to other ways of modeling other bootrom values, or going with a simpler approach (maybe it's too early for a
struct GameboyConfig
infpt-cli
?).