Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console + code viewer + fixes #41

Merged
merged 25 commits into from
May 22, 2024
Merged

Console + code viewer + fixes #41

merged 25 commits into from
May 22, 2024

Conversation

pineman
Copy link
Owner

@pineman pineman commented May 6, 2024

  • redesign debug panel
  • initial console - with rudimentary d disasm command
  • removes the fpt-cli crate (sorry @joajfreitas 😞) - as we've been talking about, the debugger should be integrated in the gameboy/cpu and not in a different crate which controls it. egui is our main gameboy client now. some code will be reused (and already has been, like disasm) but lots won't
  • code viewer - mnemonics and args of all instructions that were actually ran
  • tweak core emulator loop to allow breakpoints
  • fix tetris jumping to bootrom (RST 0x28) - properly unload the bootrom (we forgot)

@pineman pineman force-pushed the graphical-debugger branch from d57662b to 909bc2e Compare May 6, 2024 12:01
@pineman pineman changed the title a lot of changes Console + code viewer + fixes May 20, 2024
@pineman pineman marked this pull request as ready for review May 20, 2024 02:03
@pineman pineman requested review from joajfreitas and diogotito and removed request for joajfreitas May 20, 2024 02:04
@pineman pineman force-pushed the graphical-debugger branch from f57668c to cbc5495 Compare May 20, 2024 02:04
Copy link
Collaborator

@diogotito diogotito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine.
Just look at my comment in fpt/src/lr35902.rs line 1666.

fpt/src/lr35902.rs Outdated Show resolved Hide resolved
fpt/src/lr35902.rs Outdated Show resolved Hide resolved
fpt-egui/src/main.rs Show resolved Hide resolved
fpt-egui/src/main.rs Outdated Show resolved Hide resolved
fpt-egui/src/main.rs Outdated Show resolved Hide resolved
fpt-egui/src/main.rs Show resolved Hide resolved
fpt-egui/src/main.rs Show resolved Hide resolved
@pineman pineman merged commit 572bd94 into main May 22, 2024
1 check passed
@pineman pineman deleted the graphical-debugger branch May 22, 2024 22:45
joajfreitas pushed a commit that referenced this pull request Jul 13, 2024
@joajfreitas joajfreitas added the enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants