do not override port if defined in host #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
approved these changes
Jul 3, 2024
| @@ -84,8 +84,10 @@ def stub_class(self): | |||
| pass | |||
|
|
|||
| def _endpoint(self): | |||
| grpcHost = self.config.host.replace("https://", "") | |||
| return self._endpoint_override if self._endpoint_override else f"{grpcHost}:443" | |||
| grpc_host = self.config.host.replace("https://", "") | |||
There was a problem hiding this comment.
I wonder if this needs to be expanded to handle "http" as well. 🤔
Not that you need to fix that here, I just realized.
There was a problem hiding this comment.
It probably needs to be overhauled in general. I'll have another refactor to make it more holistic once it's needed for REST. This only fixes gRPC data plane config for now.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For an Index gRPC connection, port 443 is blindly added to the configured host for setting up the endpoint. A user should be able to specify a port for connection.
Solution
This PR will no longer append ":443" to the configured gRPC endpoint if a colon is already present in the host configuration.
Type of Change
Test Plan
Unit tests were updated for omitting and including a port in the host config. Verified that the client could connect to an Index on a port other than 443.