Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-distribution page #67

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Multi-distribution page #67

merged 5 commits into from
Mar 17, 2024

Conversation

giorez
Copy link
Contributor

@giorez giorez commented Mar 17, 2024

  • grouped building steps per distribution
  • sailfish buildinng fix

@x1y, as mentioned here are some changes I'd like to submit. thanks

giorez and others added 2 commits March 17, 2024 19:04
- grouped building steps per distribution
- sailfish buildinng fix
[source,shell]
----
1 sudo dd if=/dev/zero of=/dev/$DEVICE status=progress bs=32768 count=1
2 sudo dd if=/dev/zero of=/dev/$DEVICE status=progress bs=32768 count=$(expr $(lsblk -bno SIZE /dev/$DEVICE | head -1) \/ 32768)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "1" and "2" in front are not really good syntax. Try to only have parts of the command in the line, and "$" if it is executed as regular user and "#" if it is executed as root.

----

Only for Sailfish distribution, you ought to copy the extracted files directly into the device:
==== SailfishOS distribution needs different commands.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as above

@giorez
Copy link
Contributor Author

giorez commented Mar 17, 2024

thanks for your tips. I hope I didn't miss any in the revision I just sent.

@x1y
Copy link
Collaborator

x1y commented Mar 17, 2024

The "command 1 or command 2" part could be improved (for example by separating those, instead of writing both together) but seems fine so far.

@x1y x1y merged commit af944f8 into pine64:main Mar 17, 2024
1 check passed
@giorez
Copy link
Contributor Author

giorez commented Mar 17, 2024

thanks a lot for your help. I really appreciated your teaching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants