Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleTeam and SimpleMembership models #46

Merged
merged 15 commits into from
Jul 3, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions pinax/teams/migrations/0002_add_simple_models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# -*- coding: utf-8 -*-
# Generated by Django 1.9.7 on 2016-07-03 21:40
from __future__ import unicode_literals

from django.conf import settings
from django.db import migrations, models
import django.db.models.deletion
import django.utils.timezone


class Migration(migrations.Migration):

dependencies = [
('invitations', '0001_initial'),
migrations.swappable_dependency(settings.AUTH_USER_MODEL),
('pinax_teams', '0001_initial'),
]

operations = [
migrations.CreateModel(
name='SimpleMembership',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('state', models.CharField(choices=[(b'applied', 'applied'), (b'invited', 'invited'), (b'declined', 'declined'), (b'rejected', 'rejected'), (b'accepted', 'accepted'), (b'auto-joined', 'auto joined')], max_length=20, verbose_name='state')),
('role', models.CharField(choices=[(b'member', 'member'), (b'manager', 'manager'), (b'owner', 'owner')], default=b'member', max_length=20, verbose_name='role')),
('created', models.DateTimeField(default=django.utils.timezone.now, verbose_name='created')),
('invite', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='simple_memberships', to='invitations.JoinInvitation', verbose_name='invite')),
],
options={
'verbose_name': 'Simple Membership',
'verbose_name_plural': 'Simple Memberships',
},
),
migrations.CreateModel(
name='SimpleTeam',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('member_access', models.CharField(choices=[(b'open', 'open'), (b'application', 'by application'), (b'invitation', 'by invitation')], max_length=20, verbose_name='member access')),
('manager_access', models.CharField(choices=[(b'add someone', 'add someone'), (b'invite someone', 'invite someone')], max_length=20, verbose_name='manager access')),
],
options={
'verbose_name': 'Simple Team',
'verbose_name_plural': 'Simple Teams',
},
),
migrations.AlterModelOptions(
name='membership',
options={'verbose_name': 'Membership', 'verbose_name_plural': 'Memberships'},
),
migrations.AddField(
model_name='simplemembership',
name='team',
field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='memberships', to='pinax_teams.SimpleTeam', verbose_name='team'),
),
migrations.AddField(
model_name='simplemembership',
name='user',
field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='simple_memberships', to=settings.AUTH_USER_MODEL, verbose_name='user'),
),
migrations.AlterUniqueTogether(
name='simplemembership',
unique_together=set([('team', 'user', 'invite')]),
),
]
143 changes: 92 additions & 51 deletions pinax/teams/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import uuid

from django.conf import settings
from django.core.exceptions import ObjectDoesNotExist
from django.core.urlresolvers import reverse
from django.db import models
from django.utils import timezone
Expand All @@ -27,8 +28,7 @@ def create_slug(name):
return slugify(name)[:50]


@python_2_unicode_compatible
class Team(models.Model):
class BaseTeam(models.Model):

MEMBER_ACCESS_OPEN = "open"
MEMBER_ACCESS_APPLICATION = "application"
Expand All @@ -48,79 +48,72 @@ class Team(models.Model):
(MANAGER_ACCESS_INVITE, _("invite someone"))
]

slug = models.SlugField(unique=True)
name = models.CharField(max_length=100, verbose_name=_("name"))
avatar = models.ImageField(upload_to=avatar_upload, blank=True, verbose_name=_("avatar"))
description = models.TextField(blank=True, verbose_name=_("description"))
member_access = models.CharField(max_length=20, choices=MEMBER_ACCESS_CHOICES, verbose_name=_("member access"))
manager_access = models.CharField(max_length=20, choices=MANAGER_ACCESS_CHOICES, verbose_name=_("manager access"))
creator = models.ForeignKey(settings.AUTH_USER_MODEL, related_name="teams_created", verbose_name=_("creator"))
created = models.DateTimeField(default=timezone.now, editable=False, verbose_name=_("created"))

def get_absolute_url(self):
return reverse("team_detail", args=[self.slug])

def __str__(self):
return self.name
class Meta:
abstract = True
verbose_name = _("Base")
verbose_name_plural = _("Bases")

def can_join(self, user):
state = self.state_for(user)
if self.member_access == Team.MEMBER_ACCESS_OPEN and state is None:
if self.member_access == BaseTeam.MEMBER_ACCESS_OPEN and state is None:
return True
elif state == Membership.STATE_INVITED:
elif state == BaseMembership.STATE_INVITED:
return True
else:
return False

def can_leave(self, user):
# managers can't leave at the moment
role = self.role_for(user)
return role == Membership.ROLE_MEMBER
return role == BaseMembership.ROLE_MEMBER

def can_apply(self, user):
state = self.state_for(user)
return self.member_access == Team.MEMBER_ACCESS_APPLICATION and state is None
return self.member_access == BaseTeam.MEMBER_ACCESS_APPLICATION and state is None

@property
def applicants(self):
return self.memberships.filter(state=Membership.STATE_APPLIED)
return self.memberships.filter(state=BaseMembership.STATE_APPLIED)

@property
def invitees(self):
return self.memberships.filter(state=Membership.STATE_INVITED)
return self.memberships.filter(state=BaseMembership.STATE_INVITED)

@property
def declines(self):
return self.memberships.filter(state=Membership.STATE_DECLINED)
return self.memberships.filter(state=BaseMembership.STATE_DECLINED)

@property
def rejections(self):
return self.memberships.filter(state=Membership.STATE_REJECTED)
return self.memberships.filter(state=BaseMembership.STATE_REJECTED)

@property
def acceptances(self):
return self.memberships.filter(state__in=[
Membership.STATE_ACCEPTED,
Membership.STATE_AUTO_JOINED]
BaseMembership.STATE_ACCEPTED,
BaseMembership.STATE_AUTO_JOINED]
)

@property
def members(self):
return self.acceptances.filter(role=Membership.ROLE_MEMBER)
return self.acceptances.filter(role=BaseMembership.ROLE_MEMBER)

@property
def managers(self):
return self.acceptances.filter(role=Membership.ROLE_MANAGER)
return self.acceptances.filter(role=BaseMembership.ROLE_MANAGER)

@property
def owners(self):
return self.acceptances.filter(role=Membership.ROLE_OWNER)
return self.acceptances.filter(role=BaseMembership.ROLE_OWNER)

def is_owner_or_manager(self, user):
return self.acceptances.filter(
role__in=[
Membership.ROLE_OWNER,
Membership.ROLE_MANAGER
BaseMembership.ROLE_OWNER,
BaseMembership.ROLE_MANAGER
],
user=user
).exists()
Expand All @@ -138,14 +131,14 @@ def is_on_team(self, user):
return self.acceptances.filter(user=user).exists()

def add_member(self, user, role=None, state=None, by=None):
# we do this, rather than put the Membership constants in declaration
# because Membership is not yet defined
# we do this, rather than put the BaseMembership constants in declaration
# because BaseMembership is not yet defined
if role is None:
role = Membership.ROLE_MEMBER
role = BaseMembership.ROLE_MEMBER
if state is None:
state = Membership.STATE_AUTO_JOINED
state = BaseMembership.STATE_AUTO_JOINED

membership, created = Membership.objects.get_or_create(
membership, created = self.memberships.get_or_create(
team=self,
user=user,
defaults={"role": role, "state": state},
Expand All @@ -154,9 +147,9 @@ def add_member(self, user, role=None, state=None, by=None):
return membership

def add_user(self, user, role, by=None):
state = Membership.STATE_AUTO_JOINED
if self.manager_access == Team.MANAGER_ACCESS_INVITE:
state = Membership.STATE_INVITED
state = BaseMembership.STATE_AUTO_JOINED
if self.manager_access == BaseTeam.MANAGER_ACCESS_INVITE:
state = BaseMembership.STATE_INVITED
membership, _ = self.memberships.get_or_create(
user=user,
defaults={"role": role, "state": state}
Expand All @@ -169,7 +162,7 @@ def invite_user(self, from_user, to_email, role, message=None):
invite = JoinInvitation.invite(from_user, to_email, message, send=False)
membership, _ = self.memberships.get_or_create(
invite=invite,
defaults={"role": role, "state": Membership.STATE_INVITED}
defaults={"role": role, "state": BaseMembership.STATE_INVITED}
)
invite.send_invite()
signals.invited_user.send(sender=self, membership=membership, by=from_user)
Expand All @@ -178,7 +171,7 @@ def invite_user(self, from_user, to_email, role, message=None):
def for_user(self, user):
try:
return self.memberships.get(user=user)
except Membership.DoesNotExist:
except ObjectDoesNotExist:
pass

def state_for(self, user):
Expand All @@ -194,19 +187,42 @@ def role_for(self, user):
if membership:
return membership.role


class SimpleTeam(BaseTeam):

class Meta:
verbose_name = _("Simple Team")
verbose_name_plural = _("Simple Teams")


@python_2_unicode_compatible
class Team(BaseTeam):

slug = models.SlugField(unique=True)
name = models.CharField(max_length=100, verbose_name=_("name"))
avatar = models.ImageField(upload_to=avatar_upload, blank=True, verbose_name=_("avatar"))
description = models.TextField(blank=True, verbose_name=_("description"))
creator = models.ForeignKey(settings.AUTH_USER_MODEL, related_name="teams_created", verbose_name=_("creator"))
created = models.DateTimeField(default=timezone.now, editable=False, verbose_name=_("created"))

class Meta:
verbose_name = _("Team")
verbose_name_plural = _("Teams")

def get_absolute_url(self):
return reverse("team_detail", args=[self.slug])

def __str__(self):
return self.name

def save(self, *args, **kwargs):
if not self.id:
self.slug = create_slug(self.name)
self.full_clean()
super(Team, self).save(*args, **kwargs)

class Meta:
verbose_name = _("Team")
verbose_name_plural = _("Teams")


@python_2_unicode_compatible
class Membership(models.Model):
class BaseMembership(models.Model):

STATE_APPLIED = "applied"
STATE_INVITED = "invited"
Expand Down Expand Up @@ -234,25 +250,25 @@ class Membership(models.Model):
(ROLE_OWNER, _("owner"))
]

team = models.ForeignKey(Team, related_name="memberships", verbose_name=_("team"))
user = models.ForeignKey(settings.AUTH_USER_MODEL, related_name="memberships", null=True, blank=True, verbose_name=_("user"))
invite = models.ForeignKey(JoinInvitation, related_name="memberships", null=True, blank=True, verbose_name=_("invite"))
state = models.CharField(max_length=20, choices=STATE_CHOICES, verbose_name=_("state"))
role = models.CharField(max_length=20, choices=ROLE_CHOICES, default=ROLE_MEMBER, verbose_name=_("role"))
created = models.DateTimeField(default=timezone.now, verbose_name=_("created"))

class Meta:
abstract = True

def is_owner(self):
return self.role == Membership.ROLE_OWNER
return self.role == BaseMembership.ROLE_OWNER

def is_manager(self):
return self.role == Membership.ROLE_MANAGER
return self.role == BaseMembership.ROLE_MANAGER

def is_member(self):
return self.role == Membership.ROLE_MEMBER
return self.role == BaseMembership.ROLE_MEMBER

def promote(self, by):
role = self.team.role_for(by)
if role in [Membership.ROLE_MANAGER, Membership.ROLE_OWNER]:
if role in [BaseMembership.ROLE_MANAGER, BaseMembership.ROLE_OWNER]:
if self.role == Membership.ROLE_MEMBER:
self.role = Membership.ROLE_MANAGER
self.save()
Expand Down Expand Up @@ -324,6 +340,30 @@ def remove(self, by=None):
def invitee(self):
return self.user or self.invite.to_user_email()


@python_2_unicode_compatible
class SimpleMembership(BaseMembership):

team = models.ForeignKey(SimpleTeam, related_name="memberships", verbose_name=_("team"))
user = models.ForeignKey(settings.AUTH_USER_MODEL, related_name="simple_memberships", null=True, blank=True, verbose_name=_("user"))
invite = models.ForeignKey(JoinInvitation, related_name="simple_memberships", null=True, blank=True, verbose_name=_("invite"))

def __str__(self):
return "{0} in {1}".format(self.user, self.team)

class Meta:
unique_together = [("team", "user", "invite")]
verbose_name = _("Simple Membership")
verbose_name_plural = _("Simple Memberships")


@python_2_unicode_compatible
class Membership(BaseMembership):

team = models.ForeignKey(Team, related_name="memberships", verbose_name=_("team"))
user = models.ForeignKey(settings.AUTH_USER_MODEL, related_name="memberships", null=True, blank=True, verbose_name=_("user"))
invite = models.ForeignKey(JoinInvitation, related_name="memberships", null=True, blank=True, verbose_name=_("invite"))

def __str__(self):
return "{0} in {1}".format(self.user, self.team)

Expand All @@ -333,4 +373,5 @@ class Meta:
verbose_name_plural = _("Memberships")


reversion.register(SimpleMembership)
reversion.register(Membership)