Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin stripe library #584

Open
wants to merge 1 commit into
base: original
Choose a base branch
from
Open

Pin stripe library #584

wants to merge 1 commit into from

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Aug 9, 2018

What's this PR do?

Any background context you want to provide?

The stripe version should be updated with every release.

What ticket or issue # does this fix?

Closes #[issue number]

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          33       33           
  Lines        1911     1911           
  Branches      175      175           
=======================================
  Hits         1896     1896           
  Misses          7        7           
  Partials        8        8
Flag Coverage Δ
#py27dj110 98.9% <ø> (ø) ⬆️
#py27dj111 98.9% <ø> (ø) ⬆️
#py27dj18 99.16% <ø> (ø) ⬆️
#py34dj110 98.9% <ø> (ø) ⬆️
#py34dj111 98.9% <ø> (ø) ⬆️
#py34dj18 99.16% <ø> (ø) ⬆️
#py34dj20 98.9% <ø> (ø) ⬆️
#py35dj110 98.9% <ø> (ø) ⬆️
#py35dj111 98.9% <ø> (ø) ⬆️
#py35dj18 99.16% <ø> (ø) ⬆️
#py35dj20 98.9% <ø> (ø) ⬆️
#py36dj111 98.9% <ø> (ø) ⬆️
#py36dj20 98.9% <ø> (ø) ⬆️
#py36dj20psql 98.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c2ec8...4dddfab. Read the comment docs.

@@ -88,7 +88,7 @@
install_requires=[
"django-appconf>=1.0.1",
"jsonfield>=1.0.3",
"stripe>=2.0",
"stripe==2.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should rather use >=2,0,<3.0.

@paltman paltman changed the base branch from master to 4.x November 26, 2021 16:04
@paltman paltman changed the title Solves #583 Pin stripe library Nov 26, 2021
@paltman paltman added the Original The original full pinax-stripe version with cached models and actions service layer label Nov 26, 2021
@paltman paltman changed the base branch from 4.x to original November 26, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Original The original full pinax-stripe version with cached models and actions service layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants