-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metadata to subscription #536
base: original
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=========================================
+ Coverage 99.4% 99.4% +<.01%
=========================================
Files 33 33
Lines 1838 1842 +4
Branches 168 169 +1
=========================================
+ Hits 1827 1831 +4
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
LGTM, although I would prefer to have it in a more generic way, since it is supported with all (updatable) models - but this is an existing problem already. |
Just did a quick check for below sections CORE RESOURCES, PAYMENT METHODS and SUBSCRIPTIONS:
To implement a generic way of this, we need to define what are the |
+1 for this |
Charges also have metadata (not handled currently by pinax-stripe). |
What's this PR do?
add metadata to subscription
Any background context you want to provide?
In my system, the billing is for the business entity, not the user. I want to track the business subscription usage.
What ticket or issue # does this fix?
Closes #[issue number]
Definition of Done (check if considered and/or addressed):