Do not call deprecated methods on stripe.Customer #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invoices method was removed on the stripe.Customer object in stripe/stripe-python@d416e9e This replaces that same logic to fetch the invoices and sync them and does it within the method itself. This should be backwards compatible with stripe-python < 2.0 as well as the 2.0 and up release. Fixes pinax#582
streeter
force-pushed
the
fix-sync-invoices
branch
from
e43cacc to
f9e88b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 33 33
Lines 1911 1911
Branches 175 175
=======================================
Hits 1896 1896
Misses 7 7
Partials 8 8
Continue to review full report at Codecov.
|
Also, use the auto_paging_iter feature of the models
4 tasks
streeter
force-pushed
the
fix-sync-invoices
branch
from
d27a73f to
96da93e
Compare
streeter
commented
Apr 24, 2019
| @@ -62,3 +62,5 @@ setenv = | |||
| passenv = | |||
| commands = | |||
| django-admin makemigrations --check -v3 --dry-run --noinput pinax_stripe | |||
| deps = | |||
There was a problem hiding this comment.
Once #631 is merged, this can be removed.
streeter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
The invoices method was removed on the stripe.Customer object in stripe/stripe-python@d416e9e
This replaces that same logic to fetch the invoices and sync them and
does it within the method itself. This should be backwards compatible
with stripe-python < 2.0 as well as the 2.0 and up release.
Any background context you want to provide?
What ticket or issue # does this fix?
Closes #582
Closes #623
Definition of Done (check if considered and/or addressed):