Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New general config option: passwordeval #117

Merged
merged 3 commits into from
Sep 13, 2014
Merged

New general config option: passwordeval #117

merged 3 commits into from
Sep 13, 2014

Conversation

imba3r
Copy link

@imba3r imba3r commented Sep 10, 2014

This should resolve #108. Let me know if I should change something.

… password is provided the command provided as passwordeval will be called with username and hostname as arguments.
resource = 'http://example.com'
password = 'testpassword'

fd, temp_path = mkstemp()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use pytest's tmpdir fixture here: https://pytest.org/latest/tmpdir.html

@untitaker
Copy link
Member

Hey @vimbaer!

Thanks for this pull request... i added quite a few notes, i hope they don't discourage you from contributing more... also, the tests fail for Python 3.

@imba3r
Copy link
Author

imba3r commented Sep 10, 2014

Hey,
thanks for your feedback! Will fix everything soonish.

@untitaker
Copy link
Member

Thanks!

untitaker added a commit that referenced this pull request Sep 13, 2014
New general config option: passwordeval
@untitaker untitaker merged commit 3ad598c into pimutils:master Sep 13, 2014
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Oct 2, 2014
Version 0.3.0
=============

*released on 20 September 2014*

- Add ``verify_fingerprint`` parameter to
  :py:class:`vdirsyncer.storage.HttpStorage`,
  :py:class:`vdirsyncer.storage.CaldavStorage` and
  :py:class:`vdirsyncer.storage.CarddavStorage`,
  see issue `#99`_ and pull request `#106`_.

- Add ``passwordeval`` parameter to :ref:`general_config`, see issue `#108`_
  and pull request `#117`_.

- Emit warnings (instead of exceptions) about certain invalid responses from
  the server, see issue `#113`_.  This is apparently required for compatibility
  with Davmail.

.. _`#99`: pimutils/vdirsyncer#99
.. _`#106`: pimutils/vdirsyncer#106
.. _`#108`: pimutils/vdirsyncer#108
.. _`#113`: pimutils/vdirsyncer#113
.. _`#117`: pimutils/vdirsyncer#117
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Oct 11, 2014
Version 0.3.0
=============

*released on 20 September 2014*

- Add ``verify_fingerprint`` parameter to
  :py:class:`vdirsyncer.storage.HttpStorage`,
  :py:class:`vdirsyncer.storage.CaldavStorage` and
  :py:class:`vdirsyncer.storage.CarddavStorage`,
  see issue `#99`_ and pull request `#106`_.

- Add ``passwordeval`` parameter to :ref:`general_config`, see issue `#108`_
  and pull request `#117`_.

- Emit warnings (instead of exceptions) about certain invalid responses from
  the server, see issue `#113`_.  This is apparently required for compatibility
  with Davmail.

.. _`#99`: pimutils/vdirsyncer#99
.. _`#106`: pimutils/vdirsyncer#106
.. _`#108`: pimutils/vdirsyncer#108
.. _`#113`: pimutils/vdirsyncer#113
.. _`#117`: pimutils/vdirsyncer#117
@kljohann
Copy link

If it's not too late I would comment that the naming of this option is somewhat unfortunate. In offlineimap remotepasseval is actually evaluated as python code. Here passwordeval is a shell command that is executed with fixed arguments. Apart from that: Exactly what I was missing. Thanks for implementing!

@untitaker
Copy link
Member

msmtp's passwordeval option also evaluates shell commands. Yes, now I think passwordcommand would've been a better name, but it's too late for now. I opened #139 for this.

@imba3r imba3r deleted the passwordeval branch December 10, 2014 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a passwordeval config option to support cli password managers like pass.
3 participants