-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New general config option: passwordeval #117
Conversation
… password is provided the command provided as passwordeval will be called with username and hostname as arguments.
resource = 'http://example.com' | ||
password = 'testpassword' | ||
|
||
fd, temp_path = mkstemp() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use pytest's tmpdir fixture here: https://pytest.org/latest/tmpdir.html
Hey @vimbaer! Thanks for this pull request... i added quite a few notes, i hope they don't discourage you from contributing more... also, the tests fail for Python 3. |
Hey, |
…passwordeval option.
Thanks! |
New general config option: passwordeval
Version 0.3.0 ============= *released on 20 September 2014* - Add ``verify_fingerprint`` parameter to :py:class:`vdirsyncer.storage.HttpStorage`, :py:class:`vdirsyncer.storage.CaldavStorage` and :py:class:`vdirsyncer.storage.CarddavStorage`, see issue `#99`_ and pull request `#106`_. - Add ``passwordeval`` parameter to :ref:`general_config`, see issue `#108`_ and pull request `#117`_. - Emit warnings (instead of exceptions) about certain invalid responses from the server, see issue `#113`_. This is apparently required for compatibility with Davmail. .. _`#99`: pimutils/vdirsyncer#99 .. _`#106`: pimutils/vdirsyncer#106 .. _`#108`: pimutils/vdirsyncer#108 .. _`#113`: pimutils/vdirsyncer#113 .. _`#117`: pimutils/vdirsyncer#117
Version 0.3.0 ============= *released on 20 September 2014* - Add ``verify_fingerprint`` parameter to :py:class:`vdirsyncer.storage.HttpStorage`, :py:class:`vdirsyncer.storage.CaldavStorage` and :py:class:`vdirsyncer.storage.CarddavStorage`, see issue `#99`_ and pull request `#106`_. - Add ``passwordeval`` parameter to :ref:`general_config`, see issue `#108`_ and pull request `#117`_. - Emit warnings (instead of exceptions) about certain invalid responses from the server, see issue `#113`_. This is apparently required for compatibility with Davmail. .. _`#99`: pimutils/vdirsyncer#99 .. _`#106`: pimutils/vdirsyncer#106 .. _`#108`: pimutils/vdirsyncer#108 .. _`#113`: pimutils/vdirsyncer#113 .. _`#117`: pimutils/vdirsyncer#117
If it's not too late I would comment that the naming of this option is somewhat unfortunate. In offlineimap |
msmtp's passwordeval option also evaluates shell commands. Yes, now I think |
This should resolve #108. Let me know if I should change something.