Shed some vestigial dev tooling #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this on top of main? That should drop the duplicated CI commits that are still shown here. |
The QUnit test was only meant to ensure that loglevel still works when used in a package tested with QUnit, which is *really* about `noConflict()`. This cuts out some extra dependencies and tooling in favor of a simpler test of the `noConflict()` function. (See pimterry#191 for more discussion here.)
Saucelabs is no longer used for any testing, and given the maintenance status here, it's a good idea to drop the Sauce-related tooling and reduce our maintenance burden. This also removes 20 (!) security vulnerabilities, including 3 that were rated "critical".
Nobody remembers why `json2.js` was there, and it doesn't seem to actually be in use.
We have not actively posted Coverage data to coveralls.io in several years and retaining the coveralls tooling adds to our maintenance support burden, so this removes it. (If we want to start using it again in the future, they now provide a GitHub Action step, which is probably a better way to do things than with the Grunt plugin we were using.) This also removes 11 security warnings including 1 that was rated "critical".
Mr0grog
force-pushed
the
191-shed-some-vestigial-stuff
branch
from
cb65909 to
d97ef5d
Compare
|
Done! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #191, this removes a bunch of dev-time tooling that we no longer actually need or use. It also happens to resolve 31 of our vulnerabilities from dependencies (based on the results of
npm audit), including 4 that were rated “critical” (there are 21 total left, 2 of which are “critical”).Removed:
noConflict(), which is what this is really about)json2.jspackage (it never seems to have actually been used)test-browsertask in Grunt.There’s still a little more easy-ish cleanup/updates to do based on #191, and I’ll work on that after this PR lands.