CI: Scannable artifact and release names. #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I go to fetch an artifact for a MicroPython build my brain is always confounded by the repetition of "pimoroni-" before each file. Change the names so the product is up-front, so the list is easier to scan-read through.
|
@helgibbons gentle nudge that me merging this might break some learning portal articles, since the product names change from "pimoroni-product-version-micropython.uf2" to "product-version-pimoroni-micropython.uf2". See: https://github.com/pimoroni/pimoroni-pico/actions/runs/8721551227?pr=933 |
|
Ta - I've updated a few things on Learn to allow for this change. Think the file names on this page might still not be quite right - looks like some of them have rogue 'picow's in front of them 🐄 |
|
That's some serious rogue Picow business going on there! I'll get those fixed up now we ... uh... have... a release 👀 to cross reference: https://github.com/pimoroni/pimoroni-pico/releases/tag/v1.23.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I go to fetch an artifact for a MicroPython build my brain is always confounded by the repetition of "pimoroni-" before each file.
Change the names so the product is up-front, so the list is easier to scan-read through.
This will break: https://github.com/pimoroni/pimoroni-pico/blob/main/setting-up-micropython.md (TODO: fix in this PR)
And probably: https://learn.pimoroni.com/article/getting-started-with-interstate-75
And: https://github.com/pimoroni/enviro/blob/b5bff82f9001409c9683be43b9f2114e7da8b430/.github/workflows/release-zip.yml#L16