Ghosting fix for Cosmic #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooh, thanks for picking up my slack here. I could not wrap my head around the necessary changes. I have no earthly clue what's happened to the CI, but it may be related to my recent changes. |
|
I think GitHub is just unhappy this evening. Hopefuly they'll fix it soon! |
|
Looks like the storm has calmed now. Not seen it broken quite like that before! Thank you again, saved my bacon here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is applying the same ghosting fix as for Galactic to Cosmic. I've just given it a brief test and it seems to be working.
The change is to apply the row selection earlier, as it appears to take a few cycles to propagate so the previous method of changing it immediately before display starts very briefly lights the previous row.