Unicorn volume fix #603
Merged
Unicorn volume fix #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you- I'm going to take it on faith that you're probably right here, and give you this glorious merge for your troubles 😆 if it transpires that we want something else, it can be changed/tweaked from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #595, this makes the volume in PicoSynth changeable, and then reflects the volume setting in the GalacticUnicorn library into that.
side question: should there be a distinct
volumewithin GalacticUnicorn at all, or should it just fully reflect PicoSynth? I've taken the approach of touching the bare minimum, but it could be done more thoroughly if desired...I think that volume is currently only
constbecause the bulk of the logic has been borrowed from the 32blit synth stuff, which has an externally set volume (via the firmware) but if I'm wrong and there's a really good reason for it, feel free to torpedo this PR 😺