Tween fix #23
Merged
Tween fix #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take a copy instead of a reference to _values, so that start isn't changing through the loop.
* Move the floating point division out of the inner loop * Use map() / list comprehensions where possible, in preference to nested loop * Don't call show() explicitly if _set() already did it * Regression test (not committed) shows identical _values being written at each step
|
Thank you for taking the time to PR this! I had to make a couple of fixes to maintain support for Python 2.7 (groan) but otherwise it works a treat. |
|
Thanks for the tweaks; I did consider python2.7 (hence __future__ division) but didn't actually run the code under that version. The round() to float is annoying, but I can't see a better alternative without separate code paths for py2/3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #22, then optimize away repeated operations in the inner loop.