MicroPython: Fix macOS bug, _logo for launcher. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove splash/logo from startup. This caused USB to balk on macOS. * Add logo into launcher. Note: We *CANNOT* run the launcher by default, this breaks Thonny support. For default launcher, import it in "main.py".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After stepping through some debugging steps with macOS/Thonny/PicoSystem on Discord it struck me that our bootsplash might be ransacking USB and causing problems where it's not fault-tolerant. I was right 😬
This changeset strips out the boot logo entirely on PicoSystem MicroPython, moving it to the "launcher.py" instead.
Note: We CANNOT run the launcher by default, this breaks Thonny support. For default launcher, import it in "main.py".
Eg:
main.pyisn't executed when you hit "stop" in Thonny (device soft reset), so it wont utterly trounce your REPL.