Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added calls to set_voltage so that motors move and stop #2

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

shane-powell
Copy link
Contributor

Nothing seems to happen in the example if voltages are not set so have added calls to set_voltage.

Also zero the voltage at the end to prevent unexpected movement when starting a new script up.

@Gadgetoid Gadgetoid merged commit 778f0d5 into pimoroni:master Apr 20, 2020
@Gadgetoid
Copy link
Member

Good catch- thank you! I wonder if this should happen automagically in the library so that some base voltage is set, or if I should just add some - gasp - documentation for this :D

@shane-powell
Copy link
Contributor Author

Perhaps make forward and reverse go full speed by default then have an optional parameter to set the voltage.

It would be cool if it worked similarly to how the explorer hat works as that's what I am using it in combination with.

Some documentation would be good. I was scratching my head for a while over the weekend wondering why it wouldn't work. Then found the set_voltage function and woosh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants