-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raspberry Pi OS Bookworm + Pep 668 #13
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8ebf5b3
Enforce use of a virtual environment.
Gadgetoid fc12d7d
Add option to manage venv if it's not detected.
Gadgetoid c8b2011
QA: Drop --format argument from ruff.
Gadgetoid d9710f7
Drop an auto venv script into ~/Pimoroni, update venv prompt
Gadgetoid 896b3b5
Switch venv location to virtualenvwrapper default.
Gadgetoid bd3bf8b
Tweaks to install and tool.pimoroni
Gadgetoid 6e4dabc
CI: Set term in check.sh for GitHub Actions.
Gadgetoid b74d0c6
Better handling of /boot/config.txt and /boot/firmware/config.txt
Gadgetoid 66f69e3
Fix VENV_DIR path.
Gadgetoid a9db28c
Fix auto_venv.sh creation.
Gadgetoid 5a2228e
install.sh: normalise whitespace.
Gadgetoid fceeafb
install.sh: rework for better error reporting and fix some bugs.
Gadgetoid e8f9443
README.md: Correct coveralls badge branch.
Gadgetoid 39d73f7
CI: Update GitHub Actions versions.
damacus 5e294af
QA: Add shellcheck and fix/ignore all issues.
Gadgetoid f0e3f93
install.sh: slightly better feedback for setup commands.
Gadgetoid d6a2c6d
install.sh: fix quoting bug in do_config_backup.
Gadgetoid 3c9d88a
install.sh: don't output printf commands.
Gadgetoid 367cd22
install.sh: drop symlink warning for /boot/config.txt.
Gadgetoid 31b961c
install.sh: drop quotes around apt packages.
Gadgetoid 6bb337c
Makefile: fail make tag if dev tools not installed.
Gadgetoid c2d4193
tox.ini: update ruff invocation to avoid deprecation warning.
Gadgetoid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My latest Pi OS install has a non-link file for
/boot/config.txt
with the contents:Need to check if this is now standard across all Pi OS installs and, in any case, check for this text and avoid emitting this warning.
A simpler path might be to avoid all this kerfuffle and always prefer
/boot/firmware/config.txt
if it exists, without any efforts to warn about other config files.Or maybe even fail outright if
/boot/firmware/config.txt
does not exist...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I found the change: RPi-Distro/pi-gen@a125344
It will be standard, but a quick test of 64bit Pi OS lite suggests it currently is not. Therefore the symlink warning is obsolete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried growhat on RiOS bookworn 32bit, and it blew up at me, this was one of the problems. It doesn't have anything in /boot/firmware/ at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grow should have a fallback to
/boot/config.txt
- do you have a full output of the install script?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try again, but nothing was added to the normal config.txt.
For now to get it working I've moved to legacy 'bullseye' and the install was ok.
I'll have another go with bookworm when I get the time. (Then for fun I'll try the EnviroHat and the WeatherHat and the led matrix pi zero sized thing if forget the name of... obviously not as much fun as you're having rewriting all of this for all the devices.
But the venv never seemed to go right either, it didn't boot to one. and then when I manually enabled it none of the modules seemed to be there when running the examples. I'll check what it actually contains properly, it might be a few days though.
(Pi Zero, so has to be the 32bit lite version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently I'm not enabling the virtual environment by default, though it should install a script into
~/Pimoroni/auto_venv.sh
which can be optionally added to~/.bashrc
.source ~/.virtualenvs/pimoroni/bin/activate
should activate the venv manually.