Fix the message list bug #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current version of Himalaya, the Vim front breaks because it
can't find headers.subject in the JSON output from Himalaya. The JSON
output today from Himalaya representing a message looks like so
```json
{
"uid": 12345,
"flags": [],
"subject": "Subject",
"subject_len": 7,
"sender": "Sender",
"sender_len": 6,
"date": "2020-12-11 06:38:19"
},
```
This reverts some of the changes in b9a9d0e, but not all of them.
|
Thanks for your help 🎉 Since the message refactor, many details broke (see #199 (comment)), the JSON API is one of them. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version of Himalaya, the Vim front breaks because it
can't find headers.subject in the JSON output from Himalaya. The JSON
output today from Himalaya representing a message looks like so
{ "uid": 12345, "flags": [], "subject": "Subject", "subject_len": 7, "sender": "Sender", "sender_len": 6, "date": "2020-12-11 06:38:19" },And the JSON for a message is structured like so
{ "response": { "content": "Some email with attachments — strings attached.\r\n", "hasAttachment": 1 } }This reverts some of the changes in b9a9d0e, but not all of them.
Resolves #208