You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In relation to registerPartials being async #68, #159, #123.
Wouldn't you think it should be sync ? Considering we move our structure application towards partials and sub-partials and also because it is only executed once. I believe in most cases does not add any significant overhead to the efficiency of the platform overall.
The walkSync is a good approach as suggested.
In relation to renaming the partials.
I have partials named [partial - specific.hbs] and gets renamed to [partial _ specific] when registering. This is kind of annoying (hífen to underscore) since if we want to use the uri paths (/user-add) directly we would face this challenge of having to rename it every time in the application instead of locate the partial right away.
The text was updated successfully, but these errors were encountered:
Hi, I am here to help out with the maintenance of this module and working through the issues and PRs. I agree on both points of your issues. The first part I just pushed a fix for on master to release soon. To your second point, I agree that it is too opinionated. I will add an option to the registration in order to specify how to translate filenames to partial names (and thus even disable it as well), which should address your use-case.
In relation to registerPartials being async #68, #159, #123.
Wouldn't you think it should be sync ? Considering we move our structure application towards partials and sub-partials and also because it is only executed once. I believe in most cases does not add any significant overhead to the efficiency of the platform overall.
The walkSync is a good approach as suggested.
In relation to renaming the partials.
I have partials named [partial - specific.hbs] and gets renamed to [partial _ specific] when registering. This is kind of annoying (hífen to underscore) since if we want to use the uri paths (/user-add) directly we would face this challenge of having to rename it every time in the application instead of locate the partial right away.
The text was updated successfully, but these errors were encountered: