Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6 #68

Merged
merged 8 commits into from
Mar 1, 2016
Merged

Release 0.6 #68

merged 8 commits into from
Mar 1, 2016

Conversation

dougwilson
Copy link
Contributor

This is a tracking issue for release 0.6.

Please keep feature requests in their own issues

If you want to make a comment on a particular change, please make the comment in the "Files changed" tab so comments are not lost during a rebase.

List of changes for release:

Testing this release

If you want to try out this release, you can install it with the following commands:

$ npm cache clean cookies
$ npm install pillarjs/cookies#0.6

@dougwilson dougwilson self-assigned this Feb 29, 2016
@dougwilson dougwilson force-pushed the 0.6 branch 2 times, most recently from 7732d65 to d0d6aba Compare February 29, 2016 02:48
@dougwilson
Copy link
Contributor Author

Ok, @jonathanong, let me know what you think of the current changes on this branch. I am also debating if the secureProxy option should be deprecated in this version as well, since it has caused confusion in the past and with the new constructor option, it's much more reasonable to set it up correctly now instead of using that work-around.

@jonathanong
Copy link
Member

secureProxy option should be deprecated in this version as well

👍 i don't see a need for it now


A [Keygrip](https://www.npmjs.com/package/keygrip) object or an array of keys can optionally be passed as _options.keys_ to enable cryptographic signing based on SHA1 HMAC, using rotated credentials.

A Boolean can optionally be passed as _options.secure_ to explicitally specify if the connection is secure, rather than this module exaiming _request_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/s examining

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next push :)

@jonathanong
Copy link
Member

looks good!

@dougwilson
Copy link
Contributor Author

Ok, @jonathanong, I also added the secureProxy deprecation.

@dougwilson
Copy link
Contributor Author

@jonathanong, since this release was thrown together really quick, I'm just sitting on it to make sure I don't remember something too late (like forgetting something at home starting on a car tip). I'll release & publish this as 0.6.0 2/29 night if I don't hear anything.

@jonathanong
Copy link
Member

yeah, i think it's good. no rush!

@fengmk2
Copy link
Member

fengmk2 commented Feb 29, 2016

How about release 1.0.0?

@dougwilson
Copy link
Contributor Author

Hi @fengmk2, that will still happen, the idea of this was to get something out to address the koa issue; currently 1.0.0 requires changes to the keygrip module that are in flux, and security issues have been called out on the pending implementation off that module we need to address before releasing.

@fengmk2
Copy link
Member

fengmk2 commented Feb 29, 2016

👍 @dougwilson

@dougwilson
Copy link
Contributor Author

Alright everyone, going to cut a 0.6.0 release from this pull request now :)

@dougwilson dougwilson merged commit c7cf922 into master Mar 1, 2016
@dougwilson dougwilson deleted the 0.6 branch March 1, 2016 02:02
@dougwilson dougwilson added the pr label Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants