-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.6 #68
Release 0.6 #68
Conversation
7732d65
to
d0d6aba
Compare
Ok, @jonathanong, let me know what you think of the current changes on this branch. I am also debating if the |
👍 i don't see a need for it now |
|
||
A [Keygrip](https://www.npmjs.com/package/keygrip) object or an array of keys can optionally be passed as _options.keys_ to enable cryptographic signing based on SHA1 HMAC, using rotated credentials. | ||
|
||
A Boolean can optionally be passed as _options.secure_ to explicitally specify if the connection is secure, rather than this module exaiming _request_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/s examining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in next push :)
looks good! |
Ok, @jonathanong, I also added the |
@jonathanong, since this release was thrown together really quick, I'm just sitting on it to make sure I don't remember something too late (like forgetting something at home starting on a car tip). I'll release & publish this as 0.6.0 2/29 night if I don't hear anything. |
yeah, i think it's good. no rush! |
How about release 1.0.0? |
Hi @fengmk2, that will still happen, the idea of this was to get something out to address the koa issue; currently 1.0.0 requires changes to the |
Alright everyone, going to cut a 0.6.0 release from this pull request now :) |
This is a tracking issue for release 0.6.
Please keep feature requests in their own issues
If you want to make a comment on a particular change, please make the comment in the "Files changed" tab so comments are not lost during a rebase.
List of changes for release:
secure
constructor option for secure connection checking secure cookies behind load balancer #46 Allow the developer to send secure cookies no matter what #51new Cookies(req, res, [options])
cookies(req, res, [options]) #43prototype
for properconstructor
property Preserve Cookies.prototype #60secureProxy
option in.set
Testing this release
If you want to try out this release, you can install it with the following commands: