feat(input-number-card) #676

RonNabuurs · 2022-08-02T19:07:16Z

Description

This pull request will add an input-number card.

Related Issue

#230

Motivation and Context

I needed this for my automation of sprinklers. I have an input_number card for the time the sprinklers will turn on.

How Has This Been Tested

I have tested this on my own Home Assistant installation and locally with a docker container

Types of changes

🐛 Bug fix (non-breaking change which fixes an issue)
🚀 New feature (non-breaking change which adds functionality)
🌎 Translation (addition or update a translation)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have tested the change locally.

Misiu · 2022-08-31T13:14:01Z

@RonNabuurs can you add a screenshot showing the card like in similar PR's?

RonNabuurs · 2022-09-01T17:07:03Z

@Misiu I've added a few images. Though I found out that there was already a number-input module. So maybe I need to update this MR to reuse a lot of that code.

piitaya

Thank you for the contribution. I was a little busy so I didn't take time for review 😅

Can you add number support ? I think it can be nice to have it too 🙂
And the component can be renamed number-card instead of input_number-card.

You can also add example in the showcase yaml file.

piitaya · 2022-10-11T07:28:01Z

src/cards/input-number-card/const.ts

+
+export const INPUT_NUMBER_CARD_NAME = `${PREFIX_NAME}-input-number-card`;
+export const INPUT_NUMBER_CARD_EDITOR_NAME = `${INPUT_NUMBER_CARD_NAME}-editor`;
+export const INPUT_NUMBER_ENTITY_DOMAINS = ["input_number"];


number domain should be supported as well

It would be nice that this card works not just for input_number domain, but for setting other numeric values. For example appliances like sous vide and air fryer target temperature/time.

@spuljko What's the type of the entities you want to add support ?

@spuljko What's the type of the entities you want to add support ?

I was thinking about it, and came to counlusion that it would be better to add slider as option in template card. I will create new feature request for that.

We can't add the slider to template card. It will add too much fields on the template card editor. Why people would need to build a custom slider ?

As I've said, appliances like air fryer, kettle, rice cooker, sous vide. There are two numbers that can be set: cooking time and temperature. Then there is humidity for dehumidifiers, watering time for splinkers, position for smart bed, and lots of other uses. Making separate card for all of that would take lot of time, but having slider that can call some service would do the job.

AndrewSpec · 2022-11-23T16:59:43Z

Why it's still not merged?

piitaya · 2022-11-23T18:36:33Z

Because changes have been requested.

DannyFeliz · 2022-12-01T12:52:52Z

@piitaya, why don't you take over and fix the requested change?

PaoloTK · 2022-12-06T20:56:27Z

I hope I didn't step on any toes by doing this but since I needed the number card myself I implemented the requested fixes here:
https://github.com/piitaya/lovelace-mushroom/tree/21e7545fead0bb7213d687084fcacfdb693a207e

Also, since number and input_number are generic entities I thought it useful to add the ability to set a custom slider color. The ability to set a custom icon and slider color is here:
https://github.com/piitaya/lovelace-mushroom/tree/d4d66736de0bc395058f03eec90865b519760d09

tungmeister · 2023-01-22T23:09:19Z

Any progress on this one? It's the last thing I need to replace with a mushroom card on my mobile UI.

Daniel-dev22 · 2023-02-20T10:18:42Z

@piitaya any idea if this will ever be merged?

piitaya · 2023-02-27T13:47:31Z

@DannyFeliz I suggested some changes but the author didn't respond. Each contributor is responsible for his/her PR. It's not my job to fix others work.

For this one, I fixed the missing points (documentation, yaml showcase example, number domain supports) because of the high demand. I also added icon color and display mode (slider or buttons).

RonNabuurs · 2023-02-27T16:10:31Z

Sorry I did not respond to the suggestions you've made, but I haven't find the time to implement your suggestions. Thanks for implementing them and closing this issue/PR

bobloadmire · 2023-03-01T15:11:22Z

does this have the ability to change step sizes? i'd like to be able to snap to 5% increments for example.

piitaya · 2023-03-01T15:30:21Z

It uses the step of your number entity.

bobloadmire · 2023-03-01T15:35:42Z

Well that sucks because I can't change that. The Number Box card on HACS allows for this and works great but doesn't match the theme

RonNabuurs · 2023-03-01T15:40:27Z

You can define the number in the configuration yaml of home-assistant

input_number:
  slider:
    name: Your number
    initial: 30
    step: 30
    min: 0
    max: 240
    unit_of_measurement: Minutes

That would solve your problem right?

gbcatrinoiu · 2023-03-12T10:46:31Z

does anyone have any idea why I do not see this card after updating the mushroom integration?

* feat(input-number-card) * Add number domain support * Add doc and icon color support * Add display mode option * Update config --------- Co-authored-by: Paul Bottein <[email protected]>

piitaya requested changes Oct 11, 2022

View reviewed changes

piitaya mentioned this pull request Nov 23, 2022

[Feature]: Number card to control number and input_number entities #872

Closed

feat(input-number-card)

9729400

piitaya force-pushed the feat/input-number-card branch from b4b7761 to 9729400 Compare February 27, 2023 11:29

piitaya added 4 commits February 27, 2023 13:33

Add number domain support

73c2935

Add doc and icon color support

4270fb6

Add display mode option

71e2a1a

Update config

0109efa

piitaya merged commit fdab27f into piitaya:main Feb 27, 2023

piitaya added the enhancement New feature or request label Feb 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(input-number-card) #676

feat(input-number-card) #676

RonNabuurs commented Aug 2, 2022 •

edited

Loading

Misiu commented Aug 31, 2022

RonNabuurs commented Sep 1, 2022

piitaya left a comment •

edited

Loading

piitaya Oct 11, 2022

spuljko Nov 6, 2022

piitaya Nov 7, 2022

spuljko Nov 13, 2022

piitaya Nov 13, 2022 •

edited

Loading

spuljko Nov 13, 2022

AndrewSpec commented Nov 23, 2022

piitaya commented Nov 23, 2022

DannyFeliz commented Dec 1, 2022

PaoloTK commented Dec 6, 2022

tungmeister commented Jan 22, 2023

Daniel-dev22 commented Feb 20, 2023

piitaya commented Feb 27, 2023

RonNabuurs commented Feb 27, 2023

bobloadmire commented Mar 1, 2023

piitaya commented Mar 1, 2023

bobloadmire commented Mar 1, 2023

RonNabuurs commented Mar 1, 2023

gbcatrinoiu commented Mar 12, 2023

feat(input-number-card) #676

feat(input-number-card) #676

Conversation

RonNabuurs commented Aug 2, 2022 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

Checklist

Misiu commented Aug 31, 2022

RonNabuurs commented Sep 1, 2022

piitaya left a comment • edited Loading

Choose a reason for hiding this comment

piitaya Oct 11, 2022

Choose a reason for hiding this comment

spuljko Nov 6, 2022

Choose a reason for hiding this comment

piitaya Nov 7, 2022

Choose a reason for hiding this comment

spuljko Nov 13, 2022

Choose a reason for hiding this comment

piitaya Nov 13, 2022 • edited Loading

Choose a reason for hiding this comment

spuljko Nov 13, 2022

Choose a reason for hiding this comment

AndrewSpec commented Nov 23, 2022

piitaya commented Nov 23, 2022

DannyFeliz commented Dec 1, 2022

PaoloTK commented Dec 6, 2022

tungmeister commented Jan 22, 2023

Daniel-dev22 commented Feb 20, 2023

piitaya commented Feb 27, 2023

RonNabuurs commented Feb 27, 2023

bobloadmire commented Mar 1, 2023

piitaya commented Mar 1, 2023

bobloadmire commented Mar 1, 2023

RonNabuurs commented Mar 1, 2023

gbcatrinoiu commented Mar 12, 2023

RonNabuurs commented Aug 2, 2022 •

edited

Loading

piitaya left a comment •

edited

Loading

piitaya Nov 13, 2022 •

edited

Loading