Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display precision support #1037

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Display precision support #1037

merged 2 commits into from
Feb 27, 2023

Conversation

piitaya
Copy link
Owner

@piitaya piitaya commented Feb 27, 2023

Description

Add display precision support and update compute state display to latest version

Related Issue

This PR fixes or closes issue: fixes #1035

Motivation and Context

How Has This Been Tested

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@piitaya piitaya added the bug Something isn't working label Feb 27, 2023
@piitaya piitaya merged commit f3e6828 into main Feb 27, 2023
bryan-stewart pushed a commit to bryan-stewart/lovelace-mushroom that referenced this pull request Apr 5, 2023
* Update compute state display

* Improve percent localization
@richardvinger
Copy link

This issue seems to have returned?

I have an entity where I use HA's UI to set its precision to two decimals, as it represents a monetary value:
entity setting (precision with 2 decimals)

You can see the entity card respecting this setting, but not the mushroom template card:
shown properly by default cards but not mushroom

Additionally, the mushroom template card also doesn't respect the locale for the decimal separator (expecting "," in my context, not "."). Will file separately for this.

Running HA 2023.12 and Mushroom 3.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mushroom cards are incompatible with sensor display precision setting in 2023.3 beta
2 participants