Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the locking scope to what is actually needed #2

Open
wants to merge 2 commits into
base: defer-setchunk
Choose a base branch
from

Conversation

pietro68
Copy link
Owner

Resolves: audacity#3992

The original scope of the lock was much wider than what was needed; that was actually a remnant of an attempt when the lock was applied to the same mutex which protects ::callDispatcher. Why this unnecessarily wide scope created the issue is not really clear to me yet - again, the debugging info was not very useful.

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

+ Change evaluation order to avoid a deadlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant