-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system fixes: use include/library paths from pkg-config, and strip leading 'v' from librtlsdr version #138
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR!
Are you able to build on macOS with these changes? If so, what do you use for the dependencies (e.g. homebrew, ports)?
src/goesrecv/CMakeLists.txt
Outdated
@@ -22,10 +24,16 @@ if(NOT RTLSDR_FOUND) | |||
message(WARNING "Unable to find librtlsdr") | |||
else() | |||
add_library(rtlsdr_source rtlsdr_source.cc) | |||
# some rtlsdr versions begin with an extraneous 'v', remove it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you specify for which versions this is the case in the comment here?
The next person looking at these build files will be thankful :-)
Yes! I'm building this successfully on MacOS using librtlsdr and opencv from macports. I've only used It looks like
I'll try absolute paths first, but I'll have to test it out on my pi and elsewhere to make sure it doesn't break any builds. |
If the libraries discovered by pkg-config are installed in a nonstandard location, these are required to include their headers and link with their libraries.
Some versions of librtlsdr (including versions <= 0.5.4 built directly from source) have a leading 'v' on their versions as reported by pkg-config. This causes the version check for bias tees to yield incorrect results, preventing the use of a bias tee even if the underlying librtlsdr supports it. Removing the 'v' avoids this.
I've updated the pkg-config sections to use absolute library paths from The pkgconfig file for airspy puts the I've also noted which versions of librtlsdr have the pesky leading 'v'. |
This PR fixes two issues with the CMake build scripts I encountered on my Mac:
I'm happy to make any changes necessary to help get this merged!
I also have a few EMWIN handler fixes. I'll clean those up and probably open a separate PR once they're ready.