Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.4.0 #43

Closed
wants to merge 3 commits into from
Closed

Release 1.4.0 #43

wants to merge 3 commits into from

Conversation

bezborodow
Copy link
Collaborator

@bezborodow bezborodow commented May 26, 2023 •
edited
Loading

NEEDS TESTING

Do not merge for at least a month and after at least several users sign-off with testing. This may cause browsers to hang if not implemented correctly, and this library is a dependency of several projects.

Changes:

@bezborodow bezborodow self-assigned this May 26, 2023
@bezborodow bezborodow marked this pull request as draft May 26, 2023 19:21
@bezborodow bezborodow added the testing Needs testing label May 26, 2023
@bezborodow
Copy link
Collaborator Author

This will require more time than what I have available right now.

  1. Need to reimplement the tokeniser (grok). Possibly revisit and refactor.
  2. Will require a new test suite, since these are major changes.
  3. Will likely require a version 2.0 release number to emphasise the extent of changes here.
  4. Will probably wait until jQuery 4.0 also.

@bezborodow bezborodow closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bezborodow bezborodow

Labels
help wanted invalid testing Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support jQuery selectors
1 participant
@bezborodow