-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.5.8 #551
0.5.8 #551
Conversation
picturepan2
commented
Dec 23, 2018
- IMPORTANT: Moving Icons to a new GitHub Repo
- Add Auto width column Narrow Column #541
- Add more Menu badge support Feature request: support checkbox in menu-badge #545
- Improve 360-Degree Viewer
- Fix gulp issue Gulp issues - custom version #547
- Fix the errors in the Docs 404 in documentation for button mixins #538
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
flex-direction: column; | ||
|
||
// Copy and add more numbers if you need | ||
@include viewer-slider-size(36); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected item on line 18 to appear before line 13. Rule sets should be ordered as follows: @extends
, @includes
without @content
, properties, @includes
with @content
, nested rule sets
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
|
||
.btn { | ||
margin-top: -$unit-h; | ||
.label { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector should have depth of applicability no greater than 2, but was 3
@@ -414,6 +432,9 @@ | |||
.col-xs-1 { | |||
width: 8.33333333%; | |||
} | |||
.col-xs-auto { | |||
width: auto; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be followed by an empty line
@@ -298,6 +308,9 @@ | |||
.col-md-1 { | |||
width: 8.33333333%; | |||
} | |||
.col-md-auto { | |||
width: auto; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be followed by an empty line
@@ -240,6 +246,9 @@ | |||
.col-lg-1 { | |||
width: 8.33333333%; | |||
} | |||
.col-lg-auto { | |||
width: auto; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be followed by an empty line
@@ -182,6 +184,9 @@ | |||
.col-xl-1 { | |||
width: 8.33333333%; | |||
} | |||
.col-xl-auto { | |||
width: auto; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule declaration should be followed by an empty line
@@ -154,6 +154,12 @@ | |||
.docs-demo { | |||
padding-bottom: 1rem; | |||
padding-top: 1rem; | |||
|
|||
.card { | |||
box-shadow: 0 .25rem 1rem rgba($dark-color, .15); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered border, box-shadow, height
@@ -154,6 +154,12 @@ | |||
.docs-demo { | |||
padding-bottom: 1rem; | |||
padding-top: 1rem; | |||
|
|||
.card { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector should have depth of applicability no greater than 2, but was 3