Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.8 #551

Merged
merged 9 commits into from
Dec 23, 2018
Merged

0.5.8 #551

merged 9 commits into from
Dec 23, 2018

Conversation

picturepan2
Copy link
Owner

}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

flex-direction: column;

// Copy and add more numbers if you need
@include viewer-slider-size(36);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected item on line 18 to appear before line 13. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets

}
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline


.btn {
margin-top: -$unit-h;
.label {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

@@ -414,6 +432,9 @@
.col-xs-1 {
width: 8.33333333%;
}
.col-xs-auto {
width: auto;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@@ -298,6 +308,9 @@
.col-md-1 {
width: 8.33333333%;
}
.col-md-auto {
width: auto;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@@ -240,6 +246,9 @@
.col-lg-1 {
width: 8.33333333%;
}
.col-lg-auto {
width: auto;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@@ -182,6 +184,9 @@
.col-xl-1 {
width: 8.33333333%;
}
.col-xl-auto {
width: auto;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

@@ -154,6 +154,12 @@
.docs-demo {
padding-bottom: 1rem;
padding-top: 1rem;

.card {
box-shadow: 0 .25rem 1rem rgba($dark-color, .15);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered border, box-shadow, height

@@ -154,6 +154,12 @@
.docs-demo {
padding-bottom: 1rem;
padding-top: 1rem;

.card {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

@picturepan2 picturepan2 merged commit 2513e31 into master Dec 23, 2018
@picturepan2 picturepan2 deleted the 0.5.8 branch December 23, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants