Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Eto C# lang to 10, use file scoped namespaces #2426

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented Feb 17, 2023

This bumps the C# lang version for the Eto project to 8, and converts every file that has a use for it to use file scoped namespaces.

@Miepee Miepee changed the title Bump Eto C# lang to 11, use file scoped namespaces Bump Eto C# lang to 8, use file scoped namespaces Feb 17, 2023
@Miepee
Copy link
Contributor Author

Miepee commented Feb 17, 2023

Seems that I was mistaken, and turns out one can't actually use file scoped namespaces in .net framework. Oh well.

@Miepee Miepee closed this Feb 17, 2023
@Miepee Miepee deleted the fsn branch February 17, 2023 11:11
@Miepee Miepee restored the fsn branch February 22, 2023 18:58
@Miepee Miepee reopened this Feb 22, 2023
@Miepee
Copy link
Contributor Author

Miepee commented Feb 22, 2023

Reopened because apparently file scoped namespaces can be used with .net framework, as long as its compiled with a new-enough compiler

@cwensley cwensley changed the title Bump Eto C# lang to 8, use file scoped namespaces Bump Eto C# lang to 10, use file scoped namespaces Feb 22, 2023
@cwensley cwensley added this to the 2.7.4 milestone Feb 22, 2023
@cwensley cwensley merged commit 91a4744 into picoe:develop Feb 22, 2023
@cwensley
Copy link
Member

This is great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants