Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newlines in unwrapped Labels #2327

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

LeeARichardson
Copy link

@LeeARichardson LeeARichardson commented Sep 30, 2022

See: #2326

@LeeARichardson
Copy link
Author

This would be a breaking change so would you be interested if I do a separate PR to add an additional WrapMode for 2.x? WrapMode.NoneMultiline maybe?
I'm not able to test other platforms so is there any other work required?

@cwensley
Copy link
Member

Hey @LeeARichardson, thanks for submitting the PR! Yes all platforms should behave the same, so if doing this brings Gtk and WinForms in line with Mac and WPF I'm all for it.

Adding a separate WrapMode.Singleline or something similar so one could set the label to be single line even though there are newlines might be useful, but it is equally as easy just to remove the newlines from the string.

@cwensley cwensley added the bug label Oct 19, 2022
@cwensley cwensley added this to the 2.7.2 milestone Oct 19, 2022
@cwensley
Copy link
Member

Just did a test and everything looks great.

Thanks for the contribution! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants