Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect F# templates #2370

Closed
somelinguist opened this issue Dec 16, 2022 · 4 comments · Fixed by #2489
Closed

Incorrect F# templates #2370

somelinguist opened this issue Dec 16, 2022 · 4 comments · Fixed by #2489
Labels
Milestone

Comments

@somelinguist
Copy link

A couple of the F# app templates for Eto.Forms apps appear to have problems:

The MacOS template for F# doesn't include an item to compile the included Program.fs file.
https://github.com/picoe/Eto/blob/develop/src/Eto.Forms.Templates/content/App-FSharp/Separate/EtoApp.1.MacOS/EtoApp.1.MacOS.fsproj

The WPF template for F# contains a C# project, not an F# project:
https://github.com/picoe/Eto/tree/develop/src/Eto.Forms.Templates/content/App-FSharp/Separate/EtoApp.1.Wpf

I looked through the other project templates in the F# folder and didn't see any similar issues.

@cwensley
Copy link
Member

cwensley commented Dec 16, 2022

WPF doesn't support F# (last I checked.. maybe that has changed?), thus is why it is in C#. All of your Eto UI would still be in F# though. As for the other issue it should be an easy fix.

Thanks for the issue report!

@cwensley cwensley added the bug label Dec 16, 2022
@cwensley cwensley added this to the 2.7.x milestone Dec 16, 2022
@somelinguist
Copy link
Author

Thanks for the info!

Is WPF not supporting F# a recent thing? I remember having an old .net5 F# project with Eto.Forms that had a WPF target.

Interestingly, now that I went to run it, Windows complains I need to install .NET but won't actually install the needed version? It was a hobby project that I haven't worked on in over a year (and since abandoned), but I do remember it working at the time.

Not a big deal since the rest can still be in F#, I'm just curious. :)

@cwensley
Copy link
Member

While you can have an F# project that runs WPF, you can't use any xaml as that's not wired up last I checked.. the reason you'd have a WPF-specific project is so you can create custom WPF styles that would work with your project.

@somelinguist
Copy link
Author

Thanks. That makes sense!

cwensley added a commit to cwensley/Eto that referenced this issue May 24, 2023
@cwensley cwensley modified the milestones: 2.8.x, 2.8.0 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants