Allow button as modal closing icon.
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept `button[rel=prev]` as modal closing item
|
Thanks! |
|
I rebased the branch with |
Merged
|
@Atmos4, It's shipped with I updated the docs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept
button[rel=prev]as modal closing x-mark item.The reason to still go with
rel=preveven though it is not a valid button attribute is to allow it to be completely decoupled from the usage offormmethod, asformmethod=dialogcan be used in the footer too.Thus the following structures are both correct:
dialog > form > article > header > button[rel=prev][formmethod=dialog]dialog > form > article > footer > button[formmethod=dialog]Let me know what you think ✨