-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map and sort_by Twig filters #273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like the proposed changes @PhrozenByte, it only adds functionality and thats great. 👍 Perhaps including an example in the cookbook section of the docs and replacing the blogging instructions to use the new filter? |
Isolate build-related files from source
7 tasks
…s/Pico into feature/PicoTwigExtension
PhrozenByte
added a commit
that referenced
this pull request
Nov 30, 2015
Add map and sort_by Twig filters
PhrozenByte
added
status: Resolved
and removed
info: Feedback Needed
status: Pending Merge
labels
Nov 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a additional last-minute feature for Pico 1.0.0. Feedback is highly appreciated!
Especially the
sort_by
filter is important to allow users custom sorting algorithms apart from renaming their content files. This also makes Step 4 of our Blogging section in the docs obsolete (it btw describes the problem asort_by
filter solves pretty well). Something like this is impossible to achieve with a Twig macro, so theme designers would otherwise very often need to also write a plugin. Themap
filter is just a by-product of thesort_by
filter (better: ofPicoTwigExtension::getKeyOfVar()
).What do you think?