Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Idea] Internal 404 document #299

Closed
mayamcdougall opened this issue Dec 3, 2015 · 1 comment
Closed

[Feature Idea] Internal 404 document #299

mayamcdougall opened this issue Dec 3, 2015 · 1 comment

Comments

@mayamcdougall
Copy link
Collaborator

Now that my theme is complete, I've spent today rolling out Pico 1.0.0-beta.2 onto my server. I encountered two small issues during this, so I figured I'd open some Issues with my thoughts. 😉

I noticed that if there is no 404.md, and your page 404's, Pico will throw an exception. There's no mention of this in the Docs, it's purely suggested that 404.md is an optional item.

I don't know about you, but I don't ever really modify 404.md, because if I've done my job right, it will almost never show up. I just use the default 404.md provided in Pico's content-sample.

To me, 404.md feels unnecessary. I was thinking, why not bundle this page (or generate it) internally if it's not found in the content folder? This way if someone wants to modify their 404 page, they can just like always, but if they don't include one, there's no ill effects.

@PhrozenByte
Copy link
Collaborator

This feature will be shipped with Pico 1.1, see 00603f6 for implementation details. For feedback about this feature, please refer to #334. Thanks @smcdougall for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants