Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Archive Shouldn't Include vendor/*/*/.git directories #289

Closed
joshas opened this issue Nov 25, 2015 · 3 comments
Closed

Release Archive Shouldn't Include vendor/*/*/.git directories #289

joshas opened this issue Nov 25, 2015 · 3 comments

Comments

@joshas
Copy link

joshas commented Nov 25, 2015

While it is still in beta, it is not major issue, but just wanted to point that out.

@theshka
Copy link
Collaborator

theshka commented Nov 25, 2015

This is a had discussion, I'm afraid. Due to an outpouring of user feedback, we opt to include the vendor dir in release archives as to keep with Pico's "stupidly simple " mantra and provide "upload-and-go" functionality. We do however keep it out of the repo, and instruct developers to clone and run composer. Thanks for you feedback :)

@joshas
Copy link
Author

joshas commented Nov 25, 2015

Good idea, one step less for setup.
Just remove /vendor/twig/twig/.git/ directory in future releases, please.

PhrozenByte added a commit that referenced this issue Nov 25, 2015
@PhrozenByte
Copy link
Collaborator

Thanks @joshas for the hint about the .git dirs, reduces archive size from 8.41 MB to 339 KB 😳

btw: The only difference between the release archives and Pico's source code actually is the additional vendor dir, so - as instructed in our README.md, the user docs and on the download page - you can safely download the source code and run composer yourself. 😃

@theshka theshka changed the title Release archive shouldn't include vendors directory Release Archive Shouldn't Include vendor/*/*/.git directories Nov 26, 2015
@theshka theshka added this to the Version 1.0.0 milestone Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants