Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed outdated code #993

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Removed outdated code #993

merged 2 commits into from
Aug 31, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 27, 2019

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix a bug caused by old code where we removed features only partially. The bug has been discovered on Discourse. It is not a high-priority bug as it is only triggered when a user sets two seldomly used flags manually in setupVars.conf.

How does this PR accomplish the above?:

Remove the left over code parts and fix the IDs in the Javascript file.

What documentation changes (if any) are needed to support this PR?:

None, this is a bugfix.

@DL6ER DL6ER added the Bugfix label Aug 27, 2019
@DL6ER DL6ER added this to the v5.0 milestone Aug 27, 2019
@DL6ER DL6ER requested a review from a team August 27, 2019 15:01
@AzureMarker AzureMarker merged commit fafbc4c into devel Aug 31, 2019
@AzureMarker AzureMarker deleted the fix/removed_dead_code branch August 31, 2019 16:46
AzureMarker added a commit that referenced this pull request Sep 11, 2019
@AzureMarker AzureMarker modified the milestones: v5.0, v4.3.2 Sep 12, 2019
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-4-3-2-release-notes/23852/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants