Hide clients over time graph is no data is available #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data for the graph so we can hide it. Fixes #932 Signed-off-by: DL6ER <[email protected]>
3 tasks
AzureMarker
approved these changes
Jun 16, 2019
AzureMarker
added a commit
that referenced
this pull request
Sep 11, 2019
…vel_3 Hide clients over time graph is no data is available
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-4-3-2-release-notes/23852/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)git commit --signoff)What does this PR aim to accomplish?:
Fix #932
How does this PR accomplish the above?:
Check
databefore converting the incoming object to an array.This allows us to detect if there is any data to be shown in the graph. If there is no data, we hide the graph.
What documentation changes (if any) are needed to support this PR?:
None