Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit log button being too wide #935

Merged
merged 1 commit into from
May 31, 2019
Merged

Fix audit log button being too wide #935

merged 1 commit into from
May 31, 2019

Conversation

AzureMarker
Copy link
Contributor

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • [] I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:
Fix the button from being wider than the page:
image

How does this PR accomplish the above?:
All of the divs surrounding the button tag were unnecessary.
image

What documentation changes (if any) are needed to support this PR?:
None

@AzureMarker AzureMarker added this to the v4.3 milestone Apr 29, 2019
@AzureMarker AzureMarker requested a review from a team April 29, 2019 02:38
@AzureMarker AzureMarker force-pushed the fix/audit-log-button branch from fecbcd2 to fd7fc00 Compare April 29, 2019 02:40
@AzureMarker AzureMarker changed the base branch from release/v4.3 to devel May 19, 2019 21:12
@AzureMarker AzureMarker modified the milestones: v4.3, v5.0 May 19, 2019
@AzureMarker
Copy link
Contributor Author

Recalculating diff after dev was updated with v4.3 release branch changes.

@AzureMarker AzureMarker reopened this May 22, 2019
All of the divs surrounding the button tag were unnecessary.

Signed-off-by: Mcat12 <[email protected]>
@AzureMarker AzureMarker force-pushed the fix/audit-log-button branch from 5c2d05b to dd683cf Compare May 22, 2019 00:52
@DL6ER DL6ER merged commit de2dd71 into devel May 31, 2019
@DL6ER DL6ER deleted the fix/audit-log-button branch May 31, 2019 11:29
AzureMarker pushed a commit that referenced this pull request Sep 11, 2019
Fix audit log button being too wide
@AzureMarker AzureMarker modified the milestones: v5.0, v4.3.2 Sep 12, 2019
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-4-3-2-release-notes/23852/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants