Add CSRF token #466
Merged
Add CSRF token #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DL6ER
requested changes
Apr 3, 2017
settings.php
Outdated
| @@ -863,6 +871,7 @@ function get_FTL_data($arg) | |||
| <label for="zip_file">File input</label> | |||
| <input type="file" name="zip_file" id="zip_file"> | |||
| <p class="help-block">Upload only Pi-hole backup files.</p> | |||
| <input type="hidden" name="token" value="<?php echo $token ?>"> | |||
There was a problem hiding this comment.
This sends the token only for Import but not Export (23 lines further up). Also note that this form's action is scripts/pi-hole/php/teleporter.php which does not check the CSRF token at all
There was a problem hiding this comment.
It's under the same <form> tag, so I think it does send the token. I added the CSRF check to teleporter and relocated the token just to be sure.
DL6ER
approved these changes
Apr 5, 2017
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
Fix #463 and #465 by adding a CSRF token requirement to settings page actions and securing the debug log.
This template was created based on the work of
udemy-dl.