Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show disable timer across all devices #412

Merged
merged 2 commits into from
Feb 24, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 22, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10


Instead of locally we store the timeout parameter on the server. Hence, we are able to show the timeout counter across sessions, browsers and even devices.

Example: Disabled for 30 seconds on my computer, also shown on my Android device (after login in there):

screenshot_20170222-154333 resized

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added this to the v2.5 milestone Feb 22, 2017
@DL6ER DL6ER requested a review from PromoFaux February 22, 2017 14:48
@DL6ER
Copy link
Member Author

DL6ER commented Feb 23, 2017

@PromoFaux

screenshot at 2017-02-23 11-53-30

@PromoFaux
Copy link
Member

PromoFaux commented Feb 24, 2017

Adds the time on much quicker than my initial version, too ;)

Approved

Approved with PullApprove

@PromoFaux PromoFaux merged commit 0abee8e into devel Feb 24, 2017
@PromoFaux
Copy link
Member

One slight bug (?) if you reenable on one device, that doesn't get reflected on the other until you reload the page...

@DL6ER
Copy link
Member Author

DL6ER commented Feb 24, 2017

that doesn't get reflected on the other until you reload the page

Yes, as it is stored on the server - how should they get notified that you re-enabled it early on? There is no regular communication about that. The information on if there is a timer and how long it takes until it elapses is only transported at page loading.

@DL6ER DL6ER deleted the tweak/customDisableTimeGlovalCountdown branch February 24, 2017 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants