Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie test to login page #362

Merged
merged 2 commits into from
Jan 16, 2017
Merged

Add cookie test to login page #362

merged 2 commits into from
Jan 16, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 16, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10


Show notice if cookies are disabled on the login page (the login token cannot be stored in this case, forcing the user to re-login on every page).

If cookies are enabled: Nothing changes.

If cookies are disabled/blocked: Show info.

screenshot at 2017-01-16 15-44-14

screenshot at 2017-01-16 15-43-56

Note that this code is aware that the host name might not be pi.hole:

screenshot at 2017-01-16 15-51-06

This template was created based on the work of udemy-dl.

@AzureMarker
Copy link
Contributor

AzureMarker commented Jan 16, 2017

Approved

Approved with PullApprove

@DL6ER DL6ER merged commit 15f1a4e into devel Jan 16, 2017
@DL6ER DL6ER deleted the tweak/cookieTest branch January 16, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants