Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNSSEC to web UI #355

Merged
merged 2 commits into from
Jan 12, 2017
Merged

Add DNSSEC to web UI #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99fb6ad
Add DNSSEC to web UI
DL6ER Jan 12, 2017
225c279
Remove debug statement
DL6ER Jan 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions scripts/pi-hole/php/savesettings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,21 @@ function validDomain($domain_name)
// Check if domain-needed is requested
if(isset($_POST["DNSbogusPriv"]))
{
$extra .= "bogus-priv";
$extra .= "bogus-priv ";
}
else
{
$extra .= "no-bogus-priv";
$extra .= "no-bogus-priv ";
}

// Check if DNSSEC is requested
if(isset($_POST["DNSSEC"]))
{
$extra .= "dnssec";
}
else
{
$extra .= "no-dnssec";
}

// If there has been no error we can save the new DNS server IPs
Expand Down
17 changes: 17 additions & 0 deletions settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,19 @@ function convertseconds($argument) {
} else {
$DNSbogusPriv = true;
}

if(isset($setupVars["DNSSEC"])){
if($setupVars["DNSSEC"])
{
$DNSSEC = true;
}
else
{
$DNSSEC = false;
}
} else {
$DNSSEC = false;
}
?>
<div class="box box-warning">
<div class="box-header with-border">
Expand Down Expand Up @@ -459,6 +472,10 @@ function convertseconds($argument) {
<div class="checkbox"><label><input type="checkbox" name="DNSbogusPriv" <?php if($DNSbogusPriv){ ?>checked<?php } ?> title="bogus-priv"> never forward reverse lookups for private IP ranges</label></div>
</div>
<p>Note that enabling these two options may increase your privacy slightly, but may also prevent you from being able to access local hostnames if the Pi-Hole is not used as DHCP server</p>
<div class="form-group">
<div class="checkbox"><label><input type="checkbox" name="DNSSEC" <?php if($DNSSEC){ ?>checked<?php } ?>> Use DNSSEC</label></div>
</div>
<p>Validate DNS replies and cache DNSSEC data. When forwarding DNS queries, Pi-hole requests the DNSSEC records needed to validate the replies. Use Google or Norton DNS servers when activating DNSSEC. Note that the size of your log might increase significantly when enabling DNSSEC. A DNSSEC resolver test can be found <a href="http://dnssec.vs.uni-due.de/" target="_blank">here</a>.</p>
</div>
</div>
</div>
Expand Down