Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide the domain if the list removal fails #347

Merged
merged 3 commits into from
Jan 9, 2017

Conversation

donmahallem
Copy link
Contributor

@donmahallem donmahallem commented Jan 8, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

8


The domain keeps hidden if the removal fails. Now it gets shown again in this case. Queue had to be used as hide()'s animation could be longer than the request failure takes

This template was created based on the work of udemy-dl.

AzureMarker and others added 3 commits January 2, 2017 16:36
[RELEASE] Pi-hole Web Admin 2.3
[RELEASE] Pi-hole Web Admin 2.3.1
Currently the domain keeps hidden if the domain removal fails.
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2017

CLA assistant check
All committers have signed the CLA.

@donmahallem donmahallem changed the title Patch 1 Unhide the domain if the list removal fails Jan 8, 2017
@AzureMarker
Copy link
Contributor

AzureMarker commented Jan 8, 2017

Approved. Next time please start your work on the devel branch. ;)

Approved with PullApprove

@DL6ER
Copy link
Member

DL6ER commented Jan 9, 2017

Approved

Approved with PullApprove

@DL6ER DL6ER merged commit bc5dbac into pi-hole:devel Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants