Non standard web port breaking AdminLTE #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pi-Hole Web Admin Release v2.0
When you install Pi-hole and you run it on a non standard port, the host header check fails. My browser is asking for "192.168.1.100:31415", but Pi-hole only checks for "192.168.1.100" and the check fails and the user can never access the admin panel. Example error message: "Failed Host Check: 192.168.1.100:31415 vs http://192.168.1.100, http://192.168.1.100, http://pi.hole, http://localhost" This is easily reproducible by changing the lighttpd default port.
|
|
|
Please edit your PR and pull against Development, and also fill out the template that is provided when you initiate a PR request. Thank you. |
|
Sorry, lost the template. Its now pulled against devel. Here is the forum thread with the problem: https://discourse.pi-hole.net/t/how-do-i-install-pi-hole-on-a-synology-nas/289/46 |
|
This has actually already been fixed in dev. #275 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that generates the $AUTORIZED_HOSTNAMES array does not account for installations that deviate from the standard web port of your browser when checking for host header spoofing.
My browser is asking for "192.168.1.100:31415", but Pi-hole only checks for "192.168.1.100" and the check fails and the user can never access the admin panel.
Example error message: "Failed Host Check: 192.168.1.100:31415 vs http://192.168.1.100, http://192.168.1.100, http://pi.hole, http://localhost"
This is easily reproducible by changing the lighttpd default port.
@pi-hole/dashboard