Restructure folders #276
Merged
Restructure folders #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom self-written scripts.
Also removed help.js because it's no longer used
|
Can we revisit this now that we've removed the SELinux section from Core? If we can at least get rid of the IcoFonts and just use the glyphs required, that would be good, and should reduce our footprint by a ton. |
|
Yes, we should look a this again. I think the only conflict was with SELinux |
|
Well, come to think of it, I don't think it really affected much with the SELinux stuff, considering that was broken already... I will redo this later on! |
|
OK, this appears to be working. Ready for check and merge |
|
Seems to be fine. Tested on DO droplet. (I don't have to approve, my PR) |
|
This will also require changing the path to the add.php script in the custom blocking page on the core repo. |
|
Approved |
|
Adam says "IT'S OK TO MERGE THIS" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal. Assigning @dschaper and @jacobsalmela to sort out licensing. We're also going to need to change the name of the project.
@pi-hole/dashboard