Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the graphics time range when MAXLOGAGE is different than 24h #2585

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

Fix #2584

Screenshot showing the issue:
image

How does this PR accomplish the above?:

The PHP code now take into account the current time and the value from MAXLOGAGE option to limit the values received from the API.
Now, it only accepts values on the expected time range and ignores data outside the range.
This prevents empty timeslots from showing on the graphics.

image

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign changed the base branch from master to devel April 25, 2023 22:46
@rdwebdesign rdwebdesign force-pushed the fix/graph_maxlogage branch from fd6d8d4 to 6ce4ad9 Compare April 25, 2023 22:49
@rdwebdesign rdwebdesign requested a review from a team April 25, 2023 22:57
@rdwebdesign rdwebdesign changed the title Fix/graph maxlogage Fix the graphics time range when MAXLOGAGE is different than 24h Apr 25, 2023
@DL6ER DL6ER merged commit a44efc0 into devel Apr 26, 2023
@DL6ER DL6ER deleted the fix/graph_maxlogage branch April 26, 2023 04:50
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/option-for-change-time-range-on-the-dashboard/62634/10

@DL6ER DL6ER mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking] Dashboard graphics don't respect MAXLOGAGE limitation.
3 participants