Add privacy mode #258
Merged
Add privacy mode #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Conflicts: data.php
|
The info box suggests that all entries will be shown in the query log regardless of wether this setting is toggled or not.
|
AzureMarker
reviewed
Dec 27, 2016
| if(($status === "Pi-holed" && $showBlocked) || ($status === "OK" && $showPermitted)) | ||
| // Display blocked queries if $showBlocked is set | ||
| // Display permitted queries if $showPermitted is set and $privacyMode is disabled | ||
| if(($status === "Pi-holed" && $showBlocked) || ($status === "OK" && $showPermitted && !$privacyMode)) |
There was a problem hiding this comment.
If we're not showing any queries, it would be faster to immediately return an empty array than to parse through all the queries.
…n empty array when nothing to be shown (don't show blocked entries + privacy Mode enabled)
|
@PromoFaux I fixed that. |
|
Approved |
|
Waiting for codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discourse.pi-hole.net/t/privacy-mode-anonymize-logs/797/6
Changes proposed in this pull request:
@pi-hole/dashboard