Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few PHP 8 warnings #2563

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix a few PHP 8 warnings #2563

merged 1 commit into from
Mar 27, 2023

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix #2562

How does this PR accomplish the above?

Making sure the variables/values are set before using them.

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <[email protected]>
@rdwebdesign rdwebdesign requested a review from a team March 27, 2023 16:12
@yubiuser yubiuser linked an issue Mar 27, 2023 that may be closed by this pull request
@rdwebdesign rdwebdesign merged commit ecfadfe into devel Mar 27, 2023
@rdwebdesign rdwebdesign deleted the fix/php_warnings branch March 27, 2023 20:06
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/the-settings-page-is-not-displayed/62168/8

@DL6ER DL6ER mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdminLTE error using PHP 8+ and quad-zero gateway
3 participants