Fix successful temperature notification #2537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
PR #2516 changes the way how we handle the temperature unit. After setting it via web interface it will show a success message. However, this notification is blue instead of the usual green
This PR fixed the color and adds a small success icon.
How does this PR accomplish the above?:
utils.showAlert
expects aninfo
type message first and a success/error afterwars. Only ifinfo
has been generated, it will change the style to subsequent messages.https://github.com/pi-hole/AdminLTE/blob/b29a423b9553654f113bcdc8a82296eb6e4613d7/scripts/pi-hole/js/utils.js#L75-L76
This PR adds a
info
message (it will be barely seen, because it is replaced instantly with the success message).By submitting this pull request, I confirm the following:
git rebase
)