-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the FTL information on settings page after a FTL restart #2511
Conversation
To me this sounds like the real fix would rather be delaying the reload. This is what others do, too, for instance my router: when I click on the restart button, it shows some 10 seconds countdown before it allows any further actions on the page. The countdown is ticking down so users don't get impatient thinking that maybe nothing is happening and something has frozen. Mind that FTL may need longer than one second to restart on low end services with very many queries within 24 hours a it has to reload then after a restart. |
Well, this is actually delaying the reload, but only for a few milliseconds. Reading your comment, I think we could simply add a third state. The current PHP page shows 2 states:
We could introduce a new state using a message "FTL is restarting...". |
92c0e75
to
dfbf462
Compare
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/restart-dns-resolver-is-killing-new-ftl/60693/32 |
dfbf462
to
59b4d32
Compare
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
59b4d32
to
3b150a1
Compare
Branch was updated. |
What does this PR aim to accomplish?
This PR tries to fix a behavior affecting some installations (docker and bare metal) where the web interface button "Restart DNS resolver" causes an apparent error, while restarting FTL.
This topic from Discourse shows the problem on a bare metal install:
https://discourse.pi-hole.net/t/restart-dns-resolver-is-killing-new-ftl/60693
The real issue:
FTL is restarted, but in some cases the PHP page is reloaded before FTL is completely restarted.
The page uses the function
pidofFTL()
to read the PID, but the value is not found and "FTL is offline" message is shown.A few milliseconds after that, FTL finishes the restart process, but in some cases the restart could take seconds to finish.
Screen capture showing the behavior:
How does this PR accomplish the above?
Adding a new message and a countdown to wait for FTL to restart.
Link documentation PRs if any are needed to support this PR
none
By submitting this pull request, I confirm the following:
git rebase
)